On Thu, 14 Jun 2018, Jae Hyun Yoo wrote:
[...]
> > > +Example:
> > > + peci-bus@0 {
> >
> > 0?
> >
>
> Because the actual reg value of the peci bus is reg = <0x0 0x60> but
> anyway it's an example.
>
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> >
> > No 'reg' property?
0 is fine, but you really should have a 'reg' property.
> This is the actual peci bus node which is a parent of this MFD node:
> peci0: peci-bus@0 {
> compatible = "aspeed,ast2500-peci";
> reg = <0x0 0x60>;
> #address-cells = <1>;
> #size-cells = <0>;
> interrupts = <15>;
> clocks = <&syscon ASPEED_CLK_GATE_REFCLK>;
> resets = <&syscon ASPEED_RESET_PECI>;
> clock-frequency = <24000000>;
> msg-timing = <1>;
> addr-timing = <1>;
> rd-sampling-point = <8>;
> cmd-timeout-ms = <1000>;
> };
>
> > > + < more properties >
> >
> > Remove this.
>
> I dropped all other properties into < more properties > because I want
> to show the #address-cells and #size-cells to state its sub-nodes
> should have a single unique reg value. Should I remove this line or the
> whole parent node?
Just drop the properties which are unimportant for the example. You
do not need to replace them with anything, especially with a non-DT
compliant string.
> > > + peci-client@30 {
> > > + compatible = "intel,peci-client", "simple-mfd";
> > > + reg = <0x30>;
> > > + };
> > > +
> > > + peci-client@31 {
> > > + compatible = "intel,peci-client", "simple-mfd";
> > > + reg = <0x31>;
> > > + };
> > > + };
> >
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
