On Fri, Jun 01, 2018 at 06:26:25PM +0200, Oleg Nesterov wrote: > On 06/01, Christian Brauner wrote: > > > > security_task_kill() already behaves like a boolean function. Let's > > actually declare it as such too. > > The subject/changelog is wrong, this patch changes sigkill_pending()
Ah yes, s/security_task_kill()/sigkill_pending() Thanks! Christian > > > Signed-off-by: Christian Brauner <christ...@brauner.io> > > --- > > v1->v2: > > * unchanged > > v0->v1: > > * patch added > > --- > > kernel/signal.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/kernel/signal.c b/kernel/signal.c > > index 515fa59a0e9c..d5f9472a0935 100644 > > --- a/kernel/signal.c > > +++ b/kernel/signal.c > > @@ -1922,10 +1922,10 @@ static inline bool may_ptrace_stop(void) > > * Return non-zero if there is a SIGKILL that should be waking us up. > > * Called with the siglock held. > > */ > > -static int sigkill_pending(struct task_struct *tsk) > > +static bool sigkill_pending(struct task_struct *tsk) > > { > > - return sigismember(&tsk->pending.signal, SIGKILL) || > > - sigismember(&tsk->signal->shared_pending.signal, SIGKILL); > > + return sigismember(&tsk->pending.signal, SIGKILL) || > > + sigismember(&tsk->signal->shared_pending.signal, SIGKILL); > > } > > > > /* > > -- > > 2.17.0 > > >