On 05/29/2018 04:16 AM, Arnaud Pouliquen wrote:
. . .
>> +unroll_preparation:
>> + list_for_each_entry_continue_reverse(subdev, &rproc->subdevs, node) {
>> + if (subdev->unprepare)
>> + subdev->unprepare(subdev);
>> + }
> Here you could call rproc_unprepare_subdevices instead of duplicating
> the code.
I thought the same thing, but it won't work because we only want to
unprepare those devices that were successfully prepared. Here we are
unwinding the work that was partially done; in rproc_unprepare_subdevices()
*all* subdevices have their unprepare function called.
-Alex
