Hi Michael, I love your patch! Yet something to improve:
[auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Michael-S-Tsirkin/virtio_net-split-out-ctrl-buffer/20180419-145754 config: x86_64-randconfig-x006-201815 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers//net/virtio_net.c: In function 'virtnet_free_queues': >> drivers//net/virtio_net.c:2365:12: error: 'struct virtnet_info' has no >> member named 'err_ctrl'; did you mean 'ctrl'? kfree(vi->err_ctrl); ^~~~~~~~ ctrl drivers//net/virtio_net.c: In function 'virtnet_alloc_queues': >> drivers//net/virtio_net.c:2589:8: error: 'vq' undeclared (first use in this >> function); did you mean 'vi'? kfree(vq->ctrl); ^~ vi drivers//net/virtio_net.c:2589:8: note: each undeclared identifier is reported only once for each function it appears in vim +2365 drivers//net/virtio_net.c 2347 2348 static void virtnet_free_queues(struct virtnet_info *vi) 2349 { 2350 int i; 2351 2352 for (i = 0; i < vi->max_queue_pairs; i++) { 2353 napi_hash_del(&vi->rq[i].napi); 2354 netif_napi_del(&vi->rq[i].napi); 2355 netif_napi_del(&vi->sq[i].napi); 2356 } 2357 2358 /* We called napi_hash_del() before netif_napi_del(), 2359 * we need to respect an RCU grace period before freeing vi->rq 2360 */ 2361 synchronize_net(); 2362 2363 kfree(vi->rq); 2364 kfree(vi->sq); > 2365 kfree(vi->err_ctrl); 2366 } 2367 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
