On Tue, Apr 10, 2018 at 10:00:01AM +0200, Rafael J. Wysocki wrote:
> On Tue, Apr 10, 2018 at 9:33 AM, <yuank...@codeaurora.org> wrote:
> > +++ b/kernel/time/tick-sched.h
> > @@ -48,8 +48,8 @@ struct tick_sched {
> > unsigned long check_clocks;
> > enum tick_nohz_mode nohz_mode;
> >
> > + bool tick_stopped : 1;
> > unsigned int inidle : 1;
> > - unsigned int tick_stopped : 1;
> > unsigned int idle_active : 1;
> > unsigned int do_timer_last : 1;
> > unsigned int got_idle_tick : 1;
>
> I don't think this is a good idea at all.
>
> Please see https://lkml.org/lkml/2017/11/21/384 for example.
Joe, apw, could we get Checkpatch to whinge about _Bool in composite
types? That should immediately also disqualify using it as the base type
of bitfields.
