From: Dan Carpenter <dan.carpen...@oracle.com>

[ Upstream commit 7d54d0d38ec42559c891526f079f1e035cd4b3ae ]

The original code does this: "1 << (1 << 11)" which is undefined in C.

Fixes: dbc4deda03fe ("power: Adds support for Smart Battery System Manager")
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
Signed-off-by: Sasha Levin <alexander.le...@microsoft.com>
---
 drivers/power/supply/sbs-manager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/supply/sbs-manager.c 
b/drivers/power/supply/sbs-manager.c
index ccb4217b9638..cb6e8f66c7a2 100644
--- a/drivers/power/supply/sbs-manager.c
+++ b/drivers/power/supply/sbs-manager.c
@@ -183,7 +183,7 @@ static int sbsm_select(struct i2c_mux_core *muxc, u32 chan)
                return ret;
 
        /* chan goes from 1 ... 4 */
-       reg = 1 << BIT(SBSM_SMB_BAT_OFFSET + chan);
+       reg = BIT(SBSM_SMB_BAT_OFFSET + chan);
        ret = sbsm_write_word(data->client, SBSM_CMD_BATSYSSTATE, reg);
        if (ret)
                dev_err(dev, "Failed to select channel %i\n", chan);
-- 
2.14.1

Reply via email to