On Fri, Mar 02, 2018 at 06:52:54PM +0800, Du, Changbin wrote:
> Hello, any comment?
sry, overlooked this one
SNIP
> > diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c
> > index 68b65b1..c660fe6 100644
> > --- a/tools/perf/util/thread.c
> > +++ b/tools/perf/util/thread.c
> > @@ -212,6 +212,7 @@ static int ____thread__set_comm(struct thread *thread,
> > const char *str,
> > unwind__flush_access(thread);
> > }
> >
> > + thread->comm_changed = true;
> > thread->comm_set = true;
> >
> > return 0;
> > diff --git a/tools/perf/util/thread.h b/tools/perf/util/thread.h
> > index 40cfa36..b9a328b 100644
> > --- a/tools/perf/util/thread.h
> > +++ b/tools/perf/util/thread.h
> > @@ -27,6 +27,7 @@ struct thread {
> > int cpu;
> > refcount_t refcnt;
> > char shortname[3];
> > + bool comm_changed;
I don't like that it's in struct thread and set by generic function,
and just one command (sched) checks/sets it back.. I'd rather see it
in thread::priv area.. on the other hand it's simple enough and looks
like generic solution would be more tricky
Acked-by: Jiri Olsa <[email protected]>
jirka
