On Thu, Feb 22, 2018 at 03:17:38PM -0800, Jeremy McNicoll wrote:
> > +   if (pkg->link_info & ICM_LINK_INFO_REJECTED) {
> > +           tb_info(tb, "switch at %u.%u was rejected by ICM firmware\n",
> > +                   link, depth);
> 
> This kind of condition sounds more like an error instead of info.
> Please bump this up to tb_WARN/tb_warn ideally tb_err().

No, this is not an error.

> BTW - why do we have tb_WARN and tb_warn in drivers/thunderbolt/tb.h ?

_WARN dumps out backtrace as well.

Reply via email to