On Mon, Feb 19, 2018 at 07:19:36PM +0900, Namhyung Kim wrote: SNIP
> From b736729e83b62f97d716a011ccf4e430b614fecd Mon Sep 17 00:00:00 2001 > From: Namhyung Kim <namhy...@kernel.org> > Date: Mon, 19 Feb 2018 19:00:46 +0900 > Subject: [PATCH] perf tools: Fix paranoid check in machine__set_kernel_mmap() > > The machine__set_kernel_mmap() is to setup addresses of the kernel map > using external info. But it has a check when the address is given > from an incorrect input which should have the start and end address of > 0 (i.e. machine__process_kernel_mmap_event). > > But we also use the end address of 0 for a valid input so change it to > check both start and end addresses. > > Signed-off-by: Namhyung Kim <namhy...@kernel.org> Acked-by: Jiri Olsa <jo...@kernel.org> thanks, jirka > --- > tools/perf/util/machine.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c > index fe27ef55cbb9..12b7427444a3 100644 > --- a/tools/perf/util/machine.c > +++ b/tools/perf/util/machine.c > @@ -1226,7 +1226,7 @@ static void machine__set_kernel_mmap(struct machine > *machine, > * Be a bit paranoid here, some perf.data file came with > * a zero sized synthesized MMAP event for the kernel. > */ > - if (machine->vmlinux_maps[i]->end == 0) > + if (start == 0 && end == 0) > machine->vmlinux_maps[i]->end = ~0ULL; > } > } > -- > 2.16.1 >
