Hi, [...]
+ +static void __init ingenic_tcu_init(struct device_node *np, + enum ingenic_version id) +{ + struct ingenic_tcu *tcu; + size_t i, nb_clks; + int ret = -ENOMEM; + + if (id >= ID_JZ4770) + nb_clks = (JZ4770_CLK_LAST - JZ4740_CLK_TIMER0) + 1; + else + nb_clks = (JZ4740_CLK_LAST - JZ4740_CLK_TIMER0) + 1; + + tcu = kzalloc(sizeof(*tcu), GFP_KERNEL); + if (!tcu) { + pr_err("%s: cannot allocate memory\n", __func__);We don't need allocation error messages. Please run checkpatch.+ return; + } + + tcu->map = syscon_node_to_regmap(np->parent); + if (IS_ERR(tcu->map)) { + pr_err("%s: failed to map TCU registers\n", __func__); + goto err_free_tcu; + } + + tcu->clocks.clk_num = nb_clks;+ tcu->clocks.clks = kcalloc(nb_clks, sizeof(struct clk *), GFP_KERNEL);+ if (!tcu->clocks.clks) { + pr_err("%s: cannot allocate memory\n", __func__);We don't need allocation error messages. Please run checkpatch.
I did run checkpatch, which warned about this, but that's a false positive to me. The callback passed to CLK_OF_DECLARE() has a return type void, so there's no
way I can return -ENOMEM, and I don't want the error to be unnoticed. About the other remarks - I agree with you, I'll fix these in the V2. Thanks, -Paul
