Hi Ulf, I love your patch! Yet something to improve:
[auto build test ERROR on phy/next] [also build test ERROR on v4.15-rc4 next-20171222] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ulf-Hansson/phy-core-Re-work-runtime-PM-deployment-and-fix-an-issue/20171223-170432 base: https://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git next config: x86_64-acpi-redef (attached as .config) compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers//ata/libahci.c: In function 'ahci_rpm_get_port': >> drivers//ata/libahci.c:239:9: error: implicit declaration of function >> 'pm_runtime_get_sync'; did you mean 'ktime_get_ns'? >> [-Werror=implicit-function-declaration] return pm_runtime_get_sync(ap->dev); ^~~~~~~~~~~~~~~~~~~ ktime_get_ns drivers//ata/libahci.c: In function 'ahci_rpm_put_port': >> drivers//ata/libahci.c:251:2: error: implicit declaration of function >> 'pm_runtime_put'; did you mean 'of_node_put'? >> [-Werror=implicit-function-declaration] pm_runtime_put(ap->dev); ^~~~~~~~~~~~~~ of_node_put cc1: some warnings being treated as errors vim +251 drivers//ata/libahci.c 365cfa1e Anton Vorontsov 2010-03-28 228 bb03c640 Mika Westerberg 2016-02-18 229 /** bb03c640 Mika Westerberg 2016-02-18 230 * ahci_rpm_get_port - Make sure the port is powered on bb03c640 Mika Westerberg 2016-02-18 231 * @ap: Port to power on bb03c640 Mika Westerberg 2016-02-18 232 * bb03c640 Mika Westerberg 2016-02-18 233 * Whenever there is need to access the AHCI host registers outside of bb03c640 Mika Westerberg 2016-02-18 234 * normal execution paths, call this function to make sure the host is bb03c640 Mika Westerberg 2016-02-18 235 * actually powered on. bb03c640 Mika Westerberg 2016-02-18 236 */ bb03c640 Mika Westerberg 2016-02-18 237 static int ahci_rpm_get_port(struct ata_port *ap) bb03c640 Mika Westerberg 2016-02-18 238 { bb03c640 Mika Westerberg 2016-02-18 @239 return pm_runtime_get_sync(ap->dev); bb03c640 Mika Westerberg 2016-02-18 240 } bb03c640 Mika Westerberg 2016-02-18 241 bb03c640 Mika Westerberg 2016-02-18 242 /** bb03c640 Mika Westerberg 2016-02-18 243 * ahci_rpm_put_port - Undoes ahci_rpm_get_port() bb03c640 Mika Westerberg 2016-02-18 244 * @ap: Port to power down bb03c640 Mika Westerberg 2016-02-18 245 * bb03c640 Mika Westerberg 2016-02-18 246 * Undoes ahci_rpm_get_port() and possibly powers down the AHCI host bb03c640 Mika Westerberg 2016-02-18 247 * if it has no more active users. bb03c640 Mika Westerberg 2016-02-18 248 */ bb03c640 Mika Westerberg 2016-02-18 249 static void ahci_rpm_put_port(struct ata_port *ap) bb03c640 Mika Westerberg 2016-02-18 250 { bb03c640 Mika Westerberg 2016-02-18 @251 pm_runtime_put(ap->dev); bb03c640 Mika Westerberg 2016-02-18 252 } bb03c640 Mika Westerberg 2016-02-18 253 :::::: The code at line 251 was first introduced by commit :::::: bb03c640697155639b2e15e2aaa4c10f60bf0d5e ahci: Add functions to manage runtime PM of AHCI ports :::::: TO: Mika Westerberg <mika.westerb...@linux.intel.com> :::::: CC: Tejun Heo <t...@kernel.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
