On Mon, Dec 04, 2017 at 05:29:28PM +0800, Dave Young wrote:
> On 12/04/17 at 08:36am, Greg Kroah-Hartman wrote:
> > On Mon, Dec 04, 2017 at 10:02:16AM +0800, Dave Young wrote:
> > > +#define __ATTR_IRUSR(_name) {
> > > \
> > > + .attr = { .name = __stringify(_name), .mode = S_IRUSR }, \
> > > + .show = _name##_show, \
> > > +}
> >
> > Ick, no, as others, including Linus, have said, using IRUSER is a pain
> > in the ass to try to look up and remember what it is...
> >
> > Just use __ATTR() please, it should be fine for what you need to do,
> > which is special-case a sysfs attribute.
>
> Hmm, I was hesitating to do that because it needs either long code
> (over 80 chars) or some driver internal macros.
>
> There is already same issue in dmi-sysfs.c, it uses an internal macro
> DMI_SYSFS_ATTR for 0400 attr. I did not search all the kernel code,
> there might be more for such special cases. Maybe we can add some
> comment in sysfs.h to mention this is for some special case?
>
> I can do something similar as dmi sysfs code though.
Hm, let me look at this this afternoon when I get through some stable
patches, it shouldn't be that complex to need a whole new macro...
thanks,
greg k-h
