3.16.50-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Tim Gardner <[email protected]>

commit dd29dae00d39186890a5eaa2fe4ad8768bfd41a9 upstream.

drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous':
drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied 
to the left hand side of comparison [-Wlogical-not-parentheses]
  WARN_ON(!length > 0);

gcc version 5.2.1

Signed-off-by: Tim Gardner <[email protected]>
Cc: Jayamohan Kallickal <[email protected]>
Cc: Minh Tran <[email protected]>
Cc: John Soni Jose <[email protected]>
Cc: "James E.J. Bottomley" <[email protected]>
Reported-by: Joel Stanley <[email protected]>
Reviewed-by: Manoj Kumar <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
Signed-off-by: Arnd Bergmann <[email protected]>
Signed-off-by: Ben Hutchings <[email protected]>
---
 drivers/scsi/be2iscsi/be_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/scsi/be2iscsi/be_main.c
+++ b/drivers/scsi/be2iscsi/be_main.c
@@ -3152,7 +3152,7 @@ be_sgl_create_contiguous(void *virtual_a
 {
        WARN_ON(!virtual_address);
        WARN_ON(!physical_address);
-       WARN_ON(!length > 0);
+       WARN_ON(!length);
        WARN_ON(!sgl);
 
        sgl->va = virtual_address;

Reply via email to