On Sun, Nov 05, 2017 at 10:32:08AM +0100, Ingo Molnar wrote: > > A few spelling fixes: > > in the title: > > s/Fact out > /Factor out > > * changbin...@intel.com <changbin...@intel.com> wrote: > > > From: Changbin Du <changbin...@intel.com> > > > > The build message for fdimage/isoimage are pretty unstructured. The raw > > shell command blocks are printed. We can improve them as regular build > > system messages. Besides, writing commands in shell script is much more > > easier than in a Makefile. > > s/much more easier > /much more easy > > > > > See Ingo's suggestion here https://lkml.org/lkml/2017/10/31/124. > > > > This patch fact out the commands used for fdimage/isoimage generation from > > arch/x86/boot/Makefile to new script arch/x86/boot/genimage.sh. Then add a > > new kbuild command 'genimage' which invokes the new script. All > > fdimages/isoimage now is generated by call to 'genimage' with different > > parameters. > > s/fact out > /factors out > > s/to new script > to a new script > > s/Then add > /Then it adds > > s/a new kbuild command 'genimage' > /the new 'genimage' kbuild command > > s/All fdimages/isoimage now is generated by call to > /All fdimage/isoimage files are now generated by a call to > Sorry for these grammar errors. I alwyas forgot to write complete sentences in English. :)
> > +# $3 - kernel bzImage file > > +# $4 - mtool configuration file > > +# $5 - kernel cmdline > > +# $6 - inird image file > > +# > > The new script is much easier to read! > > Thanks, > > Ingo -- Thanks, Changbin Du
signature.asc
Description: PGP signature
