Re: [PATCH 1/3] Add a new element for the struct perf_tool, and add the --per-event-dump option for perf script

[David Ahern]

On 9/13/17 9:10 AM, yuzhoujian wrote:
> @@ -2797,7 +2801,12 @@ int cmd_script(int argc, const char **argv)
>  
>       file.path = input_name;
>       file.force = symbol_conf.force;
> -
> +     for (i = 1; argv[i] != NULL; i++) {
> +             if (strcmp(argv[i], "-O") == 0) {
> +                     script.tool.orientation_output = true;
> +                     break;
> +             }
> +     }
>       if (argc > 1 && !strncmp(argv[0], "rec", strlen("rec"))) {
>               rec_script_path = get_script_path(argv[1], RECORD_SUFFIX);
>               if (!rec_script_path)


That change should be dropped. I recall Arnaldo saying this feature does
not need a short option and the above is not how it should done anyways.