On Fri, 2017-08-25 at 19:41 +0200, Borislav Petkov wrote: Thanks Borislav for your feedback!
> On Fri, Aug 18, 2017 at 05:27:43PM -0700, Ricardo Neri wrote: > > Both head_32.S and head_64.S utilize the same value to initialize the > > control register CR0. Also, other parts of the kernel might want to access > > to this initial definition (e.g., emulation code for User-Mode Instruction > > s/to // > > > Prevention uses this state to provide a sane dummy value for CR0 when I'll make this change. > > emulating the smsw instruction). Thus, relocate this definition to a > > header file from which it can be conveniently accessed. > > > > Cc: Andrew Morton <a...@linux-foundation.org> > > Cc: Andy Lutomirski <l...@amacapital.net> > > Cc: Andy Lutomirski <l...@kernel.org> > > Cc: Borislav Petkov <b...@alien8.de> > > Cc: Brian Gerst <brge...@gmail.com> > > Cc: Dave Hansen <dave.han...@intel.com> > > Cc: Denys Vlasenko <dvlas...@redhat.com> > > Cc: H. Peter Anvin <h...@zytor.com> > > Cc: Josh Poimboeuf <jpoim...@redhat.com> > > Cc: Linus Torvalds <torva...@linux-foundation.org> > > Cc: Peter Zijlstra <pet...@infradead.org> > > Cc: Thomas Gleixner <t...@linutronix.de> > > Cc: linux-a...@vger.kernel.org > > Cc: linux...@kvack.org > > Suggested-by: Borislav Petkov <b...@alien8.de> > > Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com> > > --- > > arch/x86/include/uapi/asm/processor-flags.h | 6 ++++++ > > arch/x86/kernel/head_32.S | 3 --- > > arch/x86/kernel/head_64.S | 3 --- > > 3 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/arch/x86/include/uapi/asm/processor-flags.h > > b/arch/x86/include/uapi/asm/processor-flags.h > > index 185f3d10c194..aae1f2aa7563 100644 > > --- a/arch/x86/include/uapi/asm/processor-flags.h > > +++ b/arch/x86/include/uapi/asm/processor-flags.h > > @@ -151,5 +151,11 @@ > > #define CX86_ARR_BASE 0xc4 > > #define CX86_RCR_BASE 0xdc > > > > +/* > > + * Initial state of CR0 for head_32/64.S > > + */ > > No need for that comment. > > With the minor nitpicks addressed, you can add: > > Reviewed-by: Borislav Petkov <b...@suse.de> Thank you! Is it necessary for me to submit a v9 with these updates? Perhaps I can make these updates in branch for the maintainers to pull when/if this series is ack'ed. Thanks and BR, Ricardo
