Hi Liam and Sebastian,
> Am 29.08.2017 um 22:20 schrieb Liam Breck <l...@networkimprov.net>:
>
> Hi Nikolaus, thanks for the patch...
>
> On Tue, Aug 29, 2017 at 1:10 PM, H. Nikolaus Schaller <h...@goldelico.com>
> wrote:
>> Tested on Pyra prototype with bq27421.
>>
>> Signed-off-by: H. Nikolaus Schaller <h...@goldelico.com>
>> ---
>> drivers/power/supply/bq27xxx_battery.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/power/supply/bq27xxx_battery.c
>> b/drivers/power/supply/bq27xxx_battery.c
>> index b6c3120ca5ad..e3c878ef7c7e 100644
>> --- a/drivers/power/supply/bq27xxx_battery.c
>> +++ b/drivers/power/supply/bq27xxx_battery.c
>> @@ -688,7 +688,7 @@ static struct bq27xxx_dm_reg bq27545_dm_regs[] = {
>> #define bq27545_dm_regs 0
>> #endif
>>
>> -#if 0 /* not yet tested */
>> +#if 1 /* tested on Pyra */
>> static struct bq27xxx_dm_reg bq27421_dm_regs[] = {
>
> I think we can drop the #if and #else...#endif so it's just the
> dm_regs table, as with bq27425.
I have fixed that and did take the chance to update my OpenPandora
kernel so that I also could test and make the bq27500 working.
The biggest hurdle was to find out that I have to change the
compatible string to "ti,bq27500-1" to get non-NULL dm_regs...
[ 12.765930] bq27xxx_battery_i2c_probe name=bq27500-1-0
[ 12.771392] bq27xxx_battery_i2c_probe call setup
[ 12.874816] bq27xxx_battery_setup
[ 12.904266] bq27xxx_battery_setup: dm_regs=bf0520e0
[ 12.933380] (NULL device *): hwmon: 'bq27500-1-0' is not a valid name
attribute, please fix
[ 13.234893] bq27xxx_battery_settings
[ 13.238891] bq27xxx-battery 2-0055: invalid
battery:energy-full-design-microwatt-hours 14800000
[ 13.312469] bq27xxx_battery_set_config
[ 13.407745] bq27xxx_battery_unseal
[ 13.455993] bq27xxx_battery_update_dm_block
[ 13.460418] bq27xxx-battery 2-0055: update terminate-voltage to 3200
[ 13.694885] bq27xxx_battery_seal
Does this look ok for
bat: battery {
compatible = "simple-battery", "openpandora-battery";
voltage-min-design-microvolt = <3200000>;
energy-full-design-microwatt-hours = <14800000>;
charge-full-design-microamp-hours = <4000000>;
};
?
I will send a patch for enabling both fuel gauges and the
omap3-pandora-common.dtsi asap.
BR and thanks,
Nikolaus
