On Wed, 18 Apr 2007 12:07:56 +0200 (CEST) Jiri Slaby <[EMAIL PROTECTED]> wrote:
> + /* non-Z with old PLX */ > + if (cinfo->num_chips != -1 && (readb(cinfo->base_addr + CyPLX_VER) & > + 0x0f) == PLX_9050) > + cy_writeb(cinfo->ctl_addr + 0x4c, 0); > + else > +#ifndef CONFIG_CYZ_INTR > + if (cinfo->num_chips != -1) > +#endif > + cy_writew(cinfo->ctl_addr + 0x68, > + readw(cinfo->ctl_addr + 0x68) & ~0x0900); well that a bit nasty. We already have that IS_CYC_Z() thing. Perhaps we could turn that into a nice lowercase-named C function and provide a CONFIG_CYZ_INTR=y version which does `return 1'. Or something like that. But the above is, umm, inconsistent with the cleanups you've been doing ;) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
