Palmer Dabbelt <pal...@dabbelt.com> writes: > On Mon, 10 Jul 2017 23:31:18 PDT (-0700), m...@ellerman.id.au wrote: ... >> So if you have a functional early console (which I think you do) then >> you might be better off just making this def_bool y. > > I think that's best. The SBI's EARLY_PRINTK support is quite clean, so I > don't > see any reason to disable it. How does this look?
LGTM. cheers > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index 366f5f2cf106..cc274bbc29a7 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -268,18 +268,7 @@ config CMDLINE_OVERRIDE > If you don't know what to do here, say N. > > config EARLY_PRINTK > - bool "Early printk" > - default n > - help > - This option enables special console drivers which allow the kernel > - to print messages very early in the bootup process. > - > - This is useful for kernel debugging when your machine crashes very > - early before the console code is initialized. For normal operation > - it is not recommended because it looks ugly and doesn't cooperate > - with klogd/syslogd or the X server. You should normally N here, > - unless you want to debug such a crash. > - > + def_bool y > > source "lib/Kconfig.debug"
