Hi,
On Mon, Jun 12, 2017 at 01:12:23AM -0700, Tony Lindgren wrote:
> Commit 8ae904e3c236 ("phy: cpcap-usb: Add CPCAP PMIC USB support")
> is missing return statement as noted by Colin Ian King
> <colin.k...@canonical.com>. If the optional pins are not configured,
> we just want to return early and not attempt to configure the pins.
>
> Fixes: 8ae904e3c236 ("phy: cpcap-usb: Add CPCAP PMIC USB support")
> Reported-by: Colin Ian King <colin.k...@canonical.com>
> Signed-off-by: Tony Lindgren <t...@atomide.com>Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk> -- Sebastian > --- > drivers/phy/motorola/phy-cpcap-usb.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/phy/motorola/phy-cpcap-usb.c > b/drivers/phy/motorola/phy-cpcap-usb.c > --- a/drivers/phy/motorola/phy-cpcap-usb.c > +++ b/drivers/phy/motorola/phy-cpcap-usb.c > @@ -468,6 +468,8 @@ static int cpcap_usb_init_optional_pins(struct > cpcap_phy_ddata *ddata) > dev_info(ddata->dev, "default pins not configured: %ld\n", > PTR_ERR(ddata->pins)); > ddata->pins = NULL; > + > + return 0; > } > > ddata->pins_ulpi = pinctrl_lookup_state(ddata->pins, "ulpi"); > -- > 2.13.0 > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
signature.asc
Description: PGP signature
