Hi Sakari, Andy, > Subject: Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation > region driver > > On Wed, Jun 07, 2017 at 04:37:12PM +0300, Andy Shevchenko wrote: > > >> +static acpi_status ti_pmic_common_handler(u32 function, > > > + acpi_physical_address address, > > > + u32 bits, u64 *value, > > > + void *handler_context, > > > > > handler_context is unused. > > > > >> + int, int, u64 *), > > >> + int (*update)(struct regmap *, > > >> + int, int, u64), > > >> + struct ti_pmic_table *table, > > >> + int table_size) > > > > I would even split this to have separate update() and get() paths > > instead of having such a monster of parameters. > > I'm not really worried about the two callbacks --- you have the compexity, > which is agruably rather manageable, split into a number of caller functions. > I'd > rather keep it as-is. >
Ack
