Hi Sakari, Andy, > -----Original Message----- > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > Sent: Wednesday, June 07, 2017 2:13 PM > To: Andy Shevchenko <andy.shevche...@gmail.com> > Cc: Mani, Rajmohan <rajmohan.m...@intel.com>; Hans de Goede > <hdego...@redhat.com>; linux-kernel@vger.kernel.org; linux- > g...@vger.kernel.org; linux-a...@vger.kernel.org; Lee Jones > <lee.jo...@linaro.org>; Linus Walleij <linus.wall...@linaro.org>; Alexandre > Courbot <gnu...@gmail.com>; Rafael J. Wysocki <r...@rjwysocki.net>; Len > Brown <l...@kernel.org> > Subject: Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation > region driver > > On Wed, Jun 07, 2017 at 11:40:27PM +0300, Andy Shevchenko wrote: > > On Wed, Jun 7, 2017 at 11:10 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote: > > > On Wed, Jun 07, 2017 at 04:40:13PM +0300, Andy Shevchenko wrote: > > >> On Wed, Jun 7, 2017 at 3:15 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote: > > >> > On Tue, Jun 06, 2017 at 05:23:56PM +0300, Andy Shevchenko wrote: > > > > >> >> Follow the pattern, please, I suppose ti_pmic_tps68470.c > > >> > > >> Would it work for you? > > > > > > This is still a different driver from the tps68470 driver which is > > > an MFD driver. For clarity, I'd keep pmic as part of the name (and > > > I'd use tps68470_pmic_ prefix for internal symbols, too). > > > > > > As PMICs are typically linked to the kernel (vs. being modules), > > > there's no issue with the module name. I would suppose few if any > > > PMICs will be compiled as modules in general. > > > > > > It's not a big deal though. I'm fine either way. > > > > Okay, let's agree on tps68470_pmic for internal prefix and for file name? > > Ack. Thanks! >
Ack
