On Thu, Jun 01, 2017 at 10:04:58AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, May 16, 2017 at 07:49:42PM +0200, Jiri Olsa escreveu: > > Following tests are constantly failing on powerpc: > > > > # perf test break > > 18: Breakpoint overflow signal handler : FAILED! > > 19: Breakpoint overflow sampling : FAILED! > > > > The powerpc so far does not have support to even create > > instruction breakpoint using the perf event interface, > > so those tests fail early in the config phase. > > > > I added 'ison' callback to test struct to be able to > > disable specific test. It seems better than putting > > ifdefs directly to the test array. > > > > Link: http://lkml.kernel.org/n/tip-erwshbq6f7b7hdtu65z5a...@git.kernel.org > > Signed-off-by: Jiri Olsa <jo...@kernel.org> > > --- > > tools/perf/tests/bp_signal.c | 14 ++++++++++++++ > > tools/perf/tests/builtin-test.c | 7 +++++++ > > tools/perf/tests/tests.h | 3 +++ > > 3 files changed, 24 insertions(+) > > > > diff --git a/tools/perf/tests/bp_signal.c b/tools/perf/tests/bp_signal.c > > index e7664fe3bd33..0467c3b6d849 100644 > > --- a/tools/perf/tests/bp_signal.c > > +++ b/tools/perf/tests/bp_signal.c > > @@ -288,3 +288,17 @@ int test__bp_signal(int subtest __maybe_unused) > > return count1 == 1 && overflows == 3 && count2 == 3 && overflows_2 == 3 > > && count3 == 2 ? > > TEST_OK : TEST_FAIL; > > } > > + > > +bool test__bp_signal_is_on(void) > > Can you please rename this "_is_on()" thing to "_supported()"?
ok jirka
