On 05/30/2017 10:34 AM, Leonard Crestez wrote:
> These bits seem to be lost after a suspend/resume cycle so just set them
> again.
>
> This patch fixes ethernet suspend/resume on imx6ul-14x14-evk boards.
>
> Signed-off-by: Leonard Crestez <leonard.cres...@nxp.com>
> ---
> drivers/net/phy/micrel.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index 6a5fd18..c53ee17 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -700,6 +700,9 @@ static int kszphy_suspend(struct phy_device *phydev)
>
> static int kszphy_resume(struct phy_device *phydev)
> {
> + struct kszphy_priv *priv = phydev->priv;
> + int ret;
> +
> genphy_resume(phydev);
>
> /* Enable PHY Interrupts */
> @@ -709,6 +712,18 @@ static int kszphy_resume(struct phy_device *phydev)
> phydev->drv->config_intr(phydev);
> }
>
> + if (priv->rmii_ref_clk_sel) {
> + ret = kszphy_rmii_clk_sel(phydev, priv->rmii_ref_clk_sel_val);
> + if (ret) {
> + phydev_err(phydev,
> + "failed to set rmii reference clock\n");
> + return ret;
> + }
> + }
> +
> + if (priv->led_mode >= 0)
> + kszphy_setup_led(phydev, priv->type->led_mode_reg,
> priv->led_mode);
Should not we actually call kszphy_config_init() in order to restore
broadcast and nand disable bits as well?
If not, I would be more comfortable if we did create a specific function
that takes care of setting the reference clock and LED mode.
Other than that, LGTM!
--
Florian
