Usage of devm_of_platform_populate() simplify driver code
and save somes lines

Signed-off-by: Benjamin Gaignard <benjamin.gaign...@linaro.org>

CC: Kyungmin Park <kyungmin.p...@samsung.com>
CC: Sylwester Nawrocki <s.nawro...@samsung.com>
CC: Mauro Carvalho Chehab <mche...@kernel.org>
CC: Kukjin Kim <kg...@kernel.org>
CC: Krzysztof Kozlowski <k...@kernel.org>
CC: Javier Martinez Canillas <jav...@osg.samsung.com>
CC: linux-me...@vger.kernel.org
CC: linux-arm-ker...@lists.infradead.org
CC: linux-samsung-...@vger.kernel.org
CC: linux-kernel@vger.kernel.org
---
 drivers/media/platform/exynos4-is/fimc-is.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/media/platform/exynos4-is/fimc-is.c 
b/drivers/media/platform/exynos4-is/fimc-is.c
index 7f92144..340d906 100644
--- a/drivers/media/platform/exynos4-is/fimc-is.c
+++ b/drivers/media/platform/exynos4-is/fimc-is.c
@@ -854,7 +854,7 @@ static int fimc_is_probe(struct platform_device *pdev)
 
        vb2_dma_contig_set_max_seg_size(dev, DMA_BIT_MASK(32));
 
-       ret = of_platform_populate(dev->of_node, NULL, NULL, dev);
+       ret = devm_of_platform_populate(dev);
        if (ret < 0)
                goto err_pm;
 
@@ -864,7 +864,7 @@ static int fimc_is_probe(struct platform_device *pdev)
         */
        ret = fimc_is_register_subdevs(is);
        if (ret < 0)
-               goto err_of_dep;
+               goto err_pm;
 
        ret = fimc_is_debugfs_create(is);
        if (ret < 0)
@@ -883,8 +883,6 @@ static int fimc_is_probe(struct platform_device *pdev)
        fimc_is_debugfs_remove(is);
 err_sd:
        fimc_is_unregister_subdevs(is);
-err_of_dep:
-       of_platform_depopulate(dev);
 err_pm:
        if (!pm_runtime_enabled(dev))
                fimc_is_runtime_suspend(dev);
@@ -946,7 +944,6 @@ static int fimc_is_remove(struct platform_device *pdev)
        if (!pm_runtime_status_suspended(dev))
                fimc_is_runtime_suspend(dev);
        free_irq(is->irq, is);
-       of_platform_depopulate(dev);
        fimc_is_unregister_subdevs(is);
        vb2_dma_contig_clear_max_seg_size(dev);
        fimc_is_put_clocks(is);
-- 
1.9.1

Reply via email to