Anju T Sudhakar <a...@linux.vnet.ibm.com> writes: > --- a/arch/powerpc/include/asm/imc-pmu.h > +++ b/arch/powerpc/include/asm/imc-pmu.h > @@ -24,6 +24,7 @@ > */ > #define IMC_MAX_CHIPS 32 > #define IMC_MAX_PMUS 32 > +#define IMC_MAX_CORES 32 > > /* > * This macro is used for memory buffer allocation of > @@ -38,6 +39,11 @@ > #define IMC_NEST_MAX_PAGES 64 > > /* > + * IMC Core engine expects 8K bytes of memory for counter collection. > + */ > +#define IMC_CORE_COUNTER_MEM 8192
Any reason for this not to be in the device tree? This is the size of memory that Linux needs to give OPAL, so the size of that should probably come from OPAL rather than Linux. Otherwise, if in the future, we had a counter with an offset greater than 8192 in, we'd have no way to detect that and we'd fail silently by overwriting memory. -- Stewart Smith OPAL Architect, IBM.
