tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 4a1e31c68e9f40be32838944931178b0d9ed9162
commit: 08991e83b7286635167bab40927665a90fb00d81 fsnotify: Free
fsnotify_mark_connector when there is no mark attached
date: 4 weeks ago
reproduce:
# apt-get install sparse
git checkout 08991e83b7286635167bab40927665a90fb00d81
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
fs/notify/mark.c:88:19: sparse: symbol 'fsnotify_mark_connector_cachep' was
not declared. Should it be static?
fs/notify/mark.c:406:39: sparse: context imbalance in
'fsnotify_grab_connector' - wrong count at exit
>> arch/x86/include/asm/qspinlock.h:17:9: sparse: context imbalance in
>> 'fsnotify_add_mark_list' - unexpected unlock
fs/notify/mark.c:534:9: sparse: context imbalance in
'fsnotify_add_mark_locked' - unexpected unlock
fs/notify/mark.c:578:25: sparse: context imbalance in 'fsnotify_find_mark' -
unexpected unlock
fs/notify/mark.c:667:24: sparse: context imbalance in
'fsnotify_destroy_marks' - unexpected unlock
vim +/fsnotify_add_mark_list +17 arch/x86/include/asm/qspinlock.h
d73a3397 Waiman Long 2015-04-24 1 #ifndef _ASM_X86_QSPINLOCK_H
d73a3397 Waiman Long 2015-04-24 2 #define _ASM_X86_QSPINLOCK_H
d73a3397 Waiman Long 2015-04-24 3
2aa79af6 Peter Zijlstra (Intel 2015-04-24 4) #include <asm/cpufeature.h>
d73a3397 Waiman Long 2015-04-24 5 #include
<asm-generic/qspinlock_types.h>
f233f7f1 Peter Zijlstra (Intel 2015-04-24 6) #include <asm/paravirt.h>
d73a3397 Waiman Long 2015-04-24 7
d73a3397 Waiman Long 2015-04-24 8 #define queued_spin_unlock
queued_spin_unlock
d73a3397 Waiman Long 2015-04-24 9 /**
d73a3397 Waiman Long 2015-04-24 10 * queued_spin_unlock - release
a queued spinlock
d73a3397 Waiman Long 2015-04-24 11 * @lock : Pointer to queued
spinlock structure
d73a3397 Waiman Long 2015-04-24 12 *
d73a3397 Waiman Long 2015-04-24 13 * A smp_store_release() on the
least-significant byte.
d73a3397 Waiman Long 2015-04-24 14 */
f233f7f1 Peter Zijlstra (Intel 2015-04-24 15) static inline void
native_queued_spin_unlock(struct qspinlock *lock)
d73a3397 Waiman Long 2015-04-24 16 {
d73a3397 Waiman Long 2015-04-24 @17 smp_store_release((u8
*)lock, 0);
d73a3397 Waiman Long 2015-04-24 18 }
d73a3397 Waiman Long 2015-04-24 19
f233f7f1 Peter Zijlstra (Intel 2015-04-24 20) #ifdef CONFIG_PARAVIRT_SPINLOCKS
f233f7f1 Peter Zijlstra (Intel 2015-04-24 21) extern void
native_queued_spin_lock_slowpath(struct qspinlock *lock, u32 val);
f233f7f1 Peter Zijlstra (Intel 2015-04-24 22) extern void
__pv_init_lock_hash(void);
f233f7f1 Peter Zijlstra (Intel 2015-04-24 23) extern void
__pv_queued_spin_lock_slowpath(struct qspinlock *lock, u32 val);
f233f7f1 Peter Zijlstra (Intel 2015-04-24 24) extern void
__raw_callee_save___pv_queued_spin_unlock(struct qspinlock *lock);
f233f7f1 Peter Zijlstra (Intel 2015-04-24 25)
:::::: The code at line 17 was first introduced by commit
:::::: d73a33973f16ab6703e75ea00edee857afa3406e locking/qspinlock, x86: Enable
x86-64 to use queued spinlocks
:::::: TO: Waiman Long <[email protected]>
:::::: CC: Ingo Molnar <[email protected]>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
