On Tue, 2 May 2017, Gustavo A. R. Silva wrote:
> Add null check before dereferencing dev->regs pointer inside
> net2280_led_shutdown() function.
>
> Addresses-Coverity-ID: 101783
> Cc: Alan Stern <st...@rowland.harvard.edu>
> Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com>
> ---
> Changes in v2:
> Move the net2280_led_shutdown() call later.
>
> drivers/usb/gadget/udc/net2280.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/net2280.c
> b/drivers/usb/gadget/udc/net2280.c
> index 3828c2e..4f5c0c4 100644
> --- a/drivers/usb/gadget/udc/net2280.c
> +++ b/drivers/usb/gadget/udc/net2280.c
> @@ -3573,7 +3573,6 @@ static void net2280_remove(struct pci_dev *pdev)
> BUG_ON(dev->driver);
>
> /* then clean up the resources we allocated during probe() */
> - net2280_led_shutdown(dev);
> if (dev->requests) {
> int i;
> for (i = 1; i < 5; i++) {
> @@ -3588,8 +3587,10 @@ static void net2280_remove(struct pci_dev *pdev)
> free_irq(pdev->irq, dev);
> if (dev->quirks & PLX_PCIE)
> pci_disable_msi(pdev);
> - if (dev->regs)
> + if (dev->regs) {
> + net2280_led_shutdown(dev);
> iounmap(dev->regs);
> + }
> if (dev->region)
> release_mem_region(pci_resource_start(pdev, 0),
> pci_resource_len(pdev, 0));
Acked-by: Alan Stern <st...@rowland.harvard.edu>
