On (04/05/17 11:08), Sergey Senozhatsky wrote:
[..]
> > stop_critical_timings(); /* don't trace print latency */
> > - call_console_drivers(ext_text, ext_len, text, len);
> > + call_console_drivers(ext_text, ext_len, text, len, msg->level);
> > start_critical_timings();
> > printk_safe_exit_irqrestore(flags);
>
> ok, so the idea is quite clear and reasonable.
>
>
> some thoughts,
> we have a system-wide suppress_message_printing() loglevel filtering
> in console_unlock() loop, which sets a limit on loglevel for all of
> the messages - we don't even msg_print_text() if the message has
> suppressible loglevel. and this implicitly restricts per-console
> maxlevels.
>
> console_unlock()
> {
> for (;;) {
> ...
> skip:
>
> if (suppress_message_printing(msg->level)) //
> console_loglevel
> goto skip;
>
> call_console_drivers(msg->level)
> {
> if (level > con->maxlevel) // con loglevel
> continue;
> ...
> }
> }
> }
>
> this can be slightly confusing. what do you think?
one more thing.
this per-console filtering ignores... the "ignore_loglevel" param.
early_param("ignore_loglevel", ignore_loglevel_setup);
module_param(ignore_loglevel, bool, S_IRUGO | S_IWUSR);
MODULE_PARM_DESC(ignore_loglevel,
"ignore loglevel setting (prints all kernel messages to the
console)");
my preference would be preserve "ignore_loglevel" behaviour. if
we are forced to 'ignore all loglevel filtering' then we should
do so.
-ss
