Re: [PATCH] sched: Prefer sibiling only if local group is under-utilized

[Peter Zijlstra]

On Wed, Mar 22, 2017 at 11:27:50PM +0530, Srikar Dronamraju wrote:

> @@ -7536,8 +7537,8 @@ static inline void update_sd_lb_stats(struct lb_env 
> *env, struct sd_lb_stats *sd
>                * the tasks on the system).
>                */
>               if (prefer_sibling && sds->local &&
> -                 group_has_capacity(env, &sds->local_stat) &&
> -                 (sgs->sum_nr_running > 1)) {
> +                 group_has_capacity(env, local) &&
> +                 (sgs->sum_nr_running > local->sum_nr_running + 1)) {
>                       sgs->group_no_capacity = 1;
>                       sgs->group_type = group_classify(sg, sgs);
>               }

Ah, yes that makes sense!

Thanks