Hi, On Tuesday, March 21, 2017 02:04:38 PM Sekhar Nori wrote: > Hi, > > On Tuesday 14 March 2017 10:06 PM, Bartlomiej Zolnierkiewicz wrote: > > Add Palmchip BK3710 PATA controller driver. > > > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> > > There are some checkpatch suggestions that are worth fixing, I think. > > [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej > Zolnierkiewicz <b.zolnier...@samsung.com> - 2017-03-14 2206.eml:277: CHECK: > Alignment should match open parenthesis > [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej > Zolnierkiewicz <b.zolnier...@samsung.com> - 2017-03-14 2206.eml:320: CHECK: > Alignment should match open parenthesis > [PATCH v2 1_3] ata: add Palmchip BK3710 PATA controller driver - Bartlomiej > Zolnierkiewicz <b.zolnier...@samsung.com> - 2017-03-14 2206.eml:489: CHECK: > Comparison to NULL could be written "!mem"
Will be fixed in v3, thanks. [ My scripts didn't run checkpatch with --strict so I haven't noticed them. ] Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
