On Tue, Mar 14, 2017 at 5:16 PM, Javier Martinez Canillas <jav...@osg.samsung.com> wrote: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > that the MODALIAS reported will always be of the form i2c:<device>. > > But this could change in the future so the correct approach is to have an > OF device ID table if the devices are registered via OF.
I'm bot sure this patch does something useful right now. Can we survive without it? I think we may. > drivers/misc/eeprom/at24.c | 189 > ++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 188 insertions(+), 1 deletion(-) It's a huge! It will increase not only driver code base but memory footprint for almost no benefit. -- With Best Regards, Andy Shevchenko
