Re: [PATCH] um: use KERN_CONT in stack dump

[Vegard Nossum]

On 12/03/2017 10:45, Richard Weinberger wrote:

Am 12.03.2017 um 10:38 schrieb Vegard Nossum:

Without KERN_CONT, the symbol will appear on a new line, making stack
traces completely unreadable:

[snip]

I think it is better to fix the root of the problem by using a single printk.
i.e.

diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c
index aa1b56f5ac68..18eddf677ec6 100644
--- a/arch/um/kernel/sysrq.c
+++ b/arch/um/kernel/sysrq.c
@@ -17,10 +17,8 @@

 static void _print_addr(void *data, unsigned long address, int reliable)
 {
-       pr_info(" [<%08lx>]", address);
-       pr_cont(" %s", reliable ? "" : "? ");
-       print_symbol("%s", address);
-       pr_cont("\n");
+       pr_info(" [<%08lx>] %s%pB\n", address, reliable ? "" : "? ",
+               (void *)address);
 }

Your patch is better.

Tested-by: Vegard Nossum <vegard.nos...@oracle.com>

Thanks,


Vegard