On Wed, Feb 15, 2017 at 09:45:37PM -0500, Steven Rostedt wrote: > On Thu, 16 Feb 2017 11:34:17 +0900 > Byungchul Park <byungchul.p...@lge.com> wrote: > > > pick_next_pushable_task(rq) has BUG_ON(rq_cpu != task_cpu(task)) when > > it returns a task other than NULL, which means that task_cpu(task) must > > be rq->cpu. So if task == next_task, then task_cpu(next_task) must be > > rq->cpu as well. Remove the redundant condition and make code simpler. > > > > By this patch, unnecessary one branch and two LOAD operations in 'if' > > statement can be avoided. > > > > Signed-off-by: Byungchul Park <byungchul.p...@lge.com> > > Reviewed-by: Steven Rostedt (VMware) <rost...@goodmis.org> > > Reviewed-by: Juri Lelli <juri.le...@arm.com> > > --- > > This is a different patch, I don't believe Juri reviewed it yet.
I will take care not to make this kind of mistake next time. Thank you very much. > > -- Steve
