On Tue, Jan 24, 2017 at 11:33 PM, Martin Kaiser <mar...@kaiser.cx> wrote: > These functions are called only by other __init functions. > Compiling for s3c2410 with CONFIG_DEBUG_SECTION_MISMATCH=y, > I get warnings like > > WARNING: vmlinux.o(.text+0x198350): > Section mismatch in reference from the function s3c2410_clk_sleep_init() > to the (unknown reference) .init.data:(unknown) >
The code looks okay but the description is not accurate. First, indeed the functions are referenced only from other __init. However the real problem is - pointed by section mismatch - that non-init functions are referencing __initdata. Exactly this is mentioned in the error above. Please, refactor the commit message to reflect the real problem. Best regards, Krzysztof > Marking the s3c...._clk_sleep() functions as __init fixes this. > > Signed-off-by: Martin Kaiser <mar...@kaiser.cx> > --- > drivers/clk/samsung/clk-s3c2410.c | 4 ++-- > drivers/clk/samsung/clk-s3c2412.c | 4 ++-- > drivers/clk/samsung/clk-s3c2443.c | 4 ++-- > drivers/clk/samsung/clk-s3c64xx.c | 4 ++-- > 4 files changed, 8 insertions(+), 8 deletions(-) >
