Hi Hans, This series look good to me. I added the comment for patch4/5. If you agree following two comment, I'll merge these series for 4.11.
- patch4 uses the EXTCON_NONE when setting the previous_cable in probe() - patch5, I don't want to use the dev_info on the fly. So, I want to drop the patch5. Regards, Chanwoo Choi On 2016년 12월 19일 15:10, Chanwoo Choi wrote: > Hi Hans, > > On 2016년 12월 19일 09:13, Hans de Goede wrote: >> When the extcon_axp288 driver was originally merged, it was merged with >> a dependency on some other driver providing platform data for it. >> >> However such another driver was never merged, so the extcon_axp288 as >> merged upstream has never worked, its probe method simply always returns >> -ENODEV. >> >> This commit drops the dependency on the pdata always being there, instead >> it treats not having pdata as the pdata having a NULL gpio_mux_control, >> something which the code was already prepared to handle. >> >> Note that the code for controlling the mux_control gpio is left in place, >> as this may be necessary to allow the axp288 pmic to properly detect the >> charger type (instead of assuming 500mA max charge current) on some >> tablets. This will make it easier for future patches to add support for >> this gpio by getting the gpio info from somewhere. >> >> Signed-off-by: Hans de Goede <[email protected]> >> --- >> drivers/extcon/extcon-axp288.c | 25 ++++++++++--------------- >> 1 file changed, 10 insertions(+), 15 deletions(-) > > Looks good to me. > Acked-by: Chanwoo Choi <[email protected]> >
