On Sat, Dec 17, 2016 at 12:04 AM, Kees Cook <keesc...@chromium.org> wrote: > On Fri, Dec 16, 2016 at 2:36 PM, Rafael J. Wysocki <raf...@kernel.org> wrote: >> On Fri, Dec 16, 2016 at 10:51 PM, Kees Cook <keesc...@chromium.org> wrote: >>> From: Emese Revfy <re.em...@gmail.com> >>> >>> This adds the missing __printf attribute which allows compile time >>> format string checking (and will be used by the coming initify gcc >>> plugin). Additionally, this fixes the warnings exposed by the attribute. >>> >>> Signed-off-by: Emese Revfy <re.em...@gmail.com> >>> [kees: split scsi/acpi, merged attr and fix, new commit messages] >>> Signed-off-by: Kees Cook <keesc...@chromium.org> >> >> This modifies code that we get from an external projiect (ACPICA) and >> the bugs should be fixed in there in the first place. > > Who should get CCed?
Fortunately, the right people are in the CC list already. :-) >> Moreover, I'm not sure if adding __printf in acpiosxf.h is a good idea. > > Why not? Because it would cause that file to diverge from its upstream counterpart which would be sort of a problem. > This is going to be needed by the initify plugin to do > correct detection of what's being passed around to functions... I guess the question is what we will miss if we don't do that specifically for ACPICA. Thanks, Rafael
