> -----Original Message----- > From: [email protected] [mailto:[email protected]] On Behalf Of Kees > Cook > Sent: Friday, December 16, 2016 3:04 PM > To: Rafael J. Wysocki <[email protected]> > Cc: Moore, Robert <[email protected]>; Linux Kernel Mailing List > <[email protected]>; Zheng, Lv <[email protected]>; Wysocki, > Rafael J <[email protected]>; Len Brown <[email protected]>; ACPI > Devel Maling List <[email protected]>; Emese Revfy > <[email protected]>; [email protected] > Subject: Re: [PATCH] acpi: Fix format string type mistakes > > On Fri, Dec 16, 2016 at 2:36 PM, Rafael J. Wysocki <[email protected]> > wrote: > > On Fri, Dec 16, 2016 at 10:51 PM, Kees Cook <[email protected]> > wrote: > >> From: Emese Revfy <[email protected]> > >> > >> This adds the missing __printf attribute which allows compile time > >> format string checking (and will be used by the coming initify gcc > >> plugin). Additionally, this fixes the warnings exposed by the > attribute. > >> > >> Signed-off-by: Emese Revfy <[email protected]> > >> [kees: split scsi/acpi, merged attr and fix, new commit messages] > >> Signed-off-by: Kees Cook <[email protected]> > > > > This modifies code that we get from an external projiect (ACPICA) and > > the bugs should be fixed in there in the first place. > > Who should get CCed? > > > Moreover, I'm not sure if adding __printf in acpiosxf.h is a good > idea. > > Why not? This is going to be needed by the initify plugin to do correct > detection of what's being passed around to functions... >
[Moore, Robert] It's compiler-dependent. > -Kees > > -- > Kees Cook > Nexus Security
