On Wed, Nov 23, 2016 at 12:38:30PM -0700, Jason Gunthorpe wrote: > On Wed, Nov 23, 2016 at 12:27:35PM -0500, Nayna Jain wrote: > > The device driver code for the event log has the init functions and > > TPM 1.2 parsing logic both defined in same file(tpm_eventlog.c). > > > > Since the initialization functions are common with the TPM 2.0 event > > log support, this patch splits tpm_eventlog.c to have only TPM 1.2 > > event log parsing logic and moves the init functions into > > tpm_eventlog_init.c. > > I think I'd rather see a tpm_eventlog1.c/tpm_eventlog2.c than this > _init thing.. > > Jason
I would rather see tpm1-eventlog.c and tpm2-eventlog.c as we already have tpm2-cmd.c for the sake of consistency. /Jarkko
