On 2016-11-07 11:32:19 [+0100], Borislav Petkov wrote: > On Thu, Nov 03, 2016 at 03:50:16PM +0100, Sebastian Andrzej Siewior wrote: > > If we try a CPU down and fail in the middle then we roll back to the > > online state. This means we would perform CPU_ONLINE() > > without invoking CPU_DEAD() for the cleanup of what was allocated in > > Are CPU_ONLINE() and CPU_DEAD() functions? Those are the states, right?
those are states. I meant here the driver specific function invoked in those states. > > index 55cd018bc1ae..3e529fd747f8 100644 > > --- a/arch/x86/kernel/cpu/mcheck/mce_amd.c > > +++ b/arch/x86/kernel/cpu/mcheck/mce_amd.c > > @@ -1097,6 +1097,9 @@ static int threshold_create_device(unsigned int cpu) > > struct threshold_bank **bp; > > int err = 0; > > > > + bp = per_cpu(threshold_banks, cpu); > > + if (bp) > > + return 0; > > <--- newline here. okay. Sebastian
