Commit-ID: 0709a008c9fadc176500ece7395b8b5b8de143e3 Gitweb: http://git.kernel.org/tip/0709a008c9fadc176500ece7395b8b5b8de143e3 Author: Yisheng Xie <xieyishe...@huawei.com> AuthorDate: Tue, 18 Oct 2016 15:33:13 +0100 Committer: Ingo Molnar <mi...@kernel.org> CommitDate: Tue, 18 Oct 2016 17:11:17 +0200
efi/arm*: Fix efi_init() error handling There's an early memmap() leak in the efi_init() error path, fix it. Signed-off-by: Yisheng Xie <xieyishe...@huawei.com> Signed-off-by: Matt Fleming <m...@codeblueprint.co.uk> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> Cc: Catalin Marinas <catalin.mari...@arm.com> Cc: Linus Torvalds <torva...@linux-foundation.org> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Will Deacon <will.dea...@arm.com> Cc: linux-...@vger.kernel.org Link: http://lkml.kernel.org/r/20161018143318.15673-4-m...@codeblueprint.co.uk Signed-off-by: Ingo Molnar <mi...@kernel.org> --- drivers/firmware/efi/arm-init.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/efi/arm-init.c b/drivers/firmware/efi/arm-init.c index 8efe130..f853ad2 100644 --- a/drivers/firmware/efi/arm-init.c +++ b/drivers/firmware/efi/arm-init.c @@ -244,8 +244,10 @@ void __init efi_init(void) "Unexpected EFI_MEMORY_DESCRIPTOR version %ld", efi.memmap.desc_version); - if (uefi_init() < 0) + if (uefi_init() < 0) { + efi_memmap_unmap(); return; + } reserve_regions(); efi_memattr_init();
