From: Dan Carpenter <dan.carpen...@oracle.com>

We should return -ENOMEM here, instead of success.

Fixes: 475fb4e8b2f4 ("efi / ACPI: load SSTDs from EFI variables")
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org>
---
 drivers/firmware/efi/efi.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 1ac199cd75e7..a4944e22f294 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -259,8 +259,10 @@ static __init int efivar_ssdt_load(void)
                }
 
                data = kmalloc(size, GFP_KERNEL);
-               if (!data)
+               if (!data) {
+                       ret = -ENOMEM;
                        goto free_entry;
+               }
 
                ret = efivar_entry_get(entry, NULL, &size, data);
                if (ret) {
-- 
2.10.0

Reply via email to