On Mon, Feb 12, 2007 at 12:45:15AM -0800, Andrew Morton wrote: > On Thu, 08 Feb 2007 17:16:15 +0530 Srinivasa Ds <[EMAIL PROTECTED]> wrote: > > > + if (p->pre_handler == pre_handler_kretprobe) > > This breaks on sparc64: > > kernel/kprobes.c: In function `report_probe': > kernel/kprobes.c:826: error: `pre_handler_kretprobe' undeclared (first use in > this function)
Andrew, Here is a patch to fix the issue, compile tested with crosstools. Sorry for the trouble. Do you want a comprehensive patch that folds all the related changes into one? Ananth -- Fix kprobes compilation breakage on sparc64 caused due to kprobes-list-all-active-probes-in-the-system.patch Signed-off-by: Ananth N Mavinakayanahalli <[EMAIL PROTECTED]> --- kernel/kprobes.c | 6 ++++++ 1 files changed, 6 insertions(+) Index: linux-2.6.20/kernel/kprobes.c =================================================================== --- linux-2.6.20.orig/kernel/kprobes.c +++ linux-2.6.20/kernel/kprobes.c @@ -780,6 +780,12 @@ int __kprobes register_kretprobe(struct return -ENOSYS; } +static int __kprobes pre_handler_kretprobe(struct kprobe *p, + struct pt_regs *regs) +{ + return 0; +} + #endif /* ARCH_SUPPORTS_KRETPROBES */ void __kprobes unregister_kretprobe(struct kretprobe *rp) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/