On Mon, Aug 01, 2016 at 09:29:57AM +0200, Dominik Brodowski wrote: > A small nitpick: > > On Mon, Aug 01, 2016 at 01:36:01AM +0200, Rafael J. Wysocki wrote: > > --- linux-pm.orig/kernel/sched/sched.h > > +++ linux-pm/kernel/sched/sched.h > > @@ -1760,7 +1760,7 @@ DECLARE_PER_CPU(struct update_util_data > > > > /** > > * cpufreq_update_util - Take a note about CPU utilization changes. > > - * @time: Current time. > > + * @rq: Runqueue to carry out the update for. > > * > > * This function is called by the scheduler on every invocation of > > * update_load_avg() on the CPU whose utilization is being updated. > > This comment seems to need an update due to the smp_processor_id() check > being moved into this function.
The callers of this have also changed - it is no longer called directly by update_load_avg(), rather via cfs_rq_util_change() from several other locations (I believe it was my patch that failed to update this comment). Could this be replaced with a more generic statement such as "called by CFS in various paths?" thanks, Steve
