Michal Kubecek <mkube...@suse.cz> wrote:
> > - /* And one copy for every other CPU */
> > - for_each_possible_cpu(i)
> > - if (newinfo->entries[i] && newinfo->entries[i] != entry1)
> > - memcpy(newinfo->entries[i], entry1, newinfo->size);
>
> These four lines should be preserved, IMHO, as 3.12 doesn't have commit
> 482cfc318559 ("netfilter: xtables: avoid percpu ruleset duplication")
> (introduced in 4.2) which removed the need for per-cpu copies.
>
> The same applies to the other two instances of translate_compat_table()
> in net/ipv4/netfilter/ip_tables.c and net/ipv6/netfilter/ip6_tables.c
>
> Florian, do you agree?
Sorry, I have to look at this in more detail.
The patches change the compat translation version into a preprocessing
step rather than a 1:1 replacement of translate_table.
>From first glance the removal is thus ok.
I will review this later today.
Also, please be aware of this bug:
http://patchwork.ozlabs.org/patch/648446/
If possible this patchset should not be pushed to all -stable
kernels yet.
