On Thu, Jul 14, 2016 at 06:39:04PM -0700, Andrey Pronin wrote:
> +static inline u16 tpm_tis_max_xfer_size(struct tpm_tis_data *data)
> +{
> + return data->phy_ops->max_xfer_size;
> +}
> +
> +static inline bool tpm_tis_burstcnt_is_valid(struct tpm_tis_data *data,
> + u16 burstcnt)
> +{
> + return (tpm_tis_max_xfer_size(data) == 0)
> + || (burstcnt <= tpm_tis_max_xfer_size(data));
> +}
We don't need these accessors, just open code it in the one call
site. That is more clear as the ==0 case is important to understand
that the flow is correct.
BTW, I dodn't think || as the start of a line was cannonical kernel
style.. Did checkpatch accept that?
Jason
