On 05/24/2016 02:27 PM, Linus Walleij wrote: > On Fri, May 13, 2016 at 8:43 PM, Crestez Dan Leonard > <leonard.cres...@intel.com> wrote: > >> This fixes a possible race where an interrupt arrives before complete >> initialization and crashes because iio_trigger_get_drvdata returns NULL. >> >> Cc: Linus Walleij <linus.wall...@linaro.org> >> Cc: Giuseppe Barba <giuseppe.ba...@st.com> >> Cc: Denis Ciocca <denis.cio...@st.com> >> Signed-off-by: Crestez Dan Leonard <leonard.cres...@intel.com> >> --- >> I ran into this while breaking the driver. But since the interrupt line can >> be >> shared the handler should always be able to accept and ignore a call. > > Reviewed-by: Linus Walleij <linus.wall...@linaro.org> > > However I think my patch fixing the thread issue will collide > by being close in context to this so it'd be great if you > could resend it on top of > "iio: st_sensors: switch to a threaded interrupt"?
I checked my local git tree and this was already on top of v6 of that patch. I think this issue is much less likely to cause problems without it. Perhaps it should be incorporated into your patch? I'll resend if it causes conflicts for Jonathan. -- Regards, Leonard
