On Tue, 23 Jan 2007 23:33:29 +0100 Blaisorblade <[EMAIL PROTECTED]> wrote:
> On Tuesday 23 January 2007 14:17, Johannes Stezenbach wrote: > > On Tue, Jan 23, 2007 at 09:02:30AM +0100, Blaisorblade wrote: > > > On Monday 22 January 2007 21:13, Johannes Stezenbach wrote: > > > > I was playing with user-mode Linux and found that mknod creates > > > > devices node in hostfs with wrong major/minor numbers. > > > > The patch below fixes it for me. > > > > > > Hmpf. Still having this bug on hostfs is quite bad. Thanks for reporting. > > I've now seen - we never fixed this one, we fixed the analogous problem > on 'ls' output and friends (in init_inode, which is used in many places). > > > > It should be hostfs_user.c to take major and minor and to combine them > > > correctly - it can use libc's macros. > > > > Right, below is a better patch. > > Exactly what I meant, thanks! > I'd say: > Acked-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> > This can go to 2.6.20, and possibly even to -stable (after either me or Jeff > tests it once). So.. did you test it? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
