Shaohua Li <s...@fb.com> writes: > On Tue, May 10, 2016 at 11:52:15AM -0400, Jeff Moyer wrote: >> Shaohua Li <s...@fb.com> writes: >> >> > if trace isn't enabled, parsing cgroup path just wastes cpu >> > >> > Signed-off-by: Shaohua Li <s...@fb.com> >> > --- >> > block/blk-throttle.c | 5 ++--- >> > include/linux/blktrace_api.h | 9 +++++++++ >> > 2 files changed, 11 insertions(+), 3 deletions(-) >> > >> > diff --git a/block/blk-throttle.c b/block/blk-throttle.c >> > index 2149a1d..47a3e54 100644 >> > --- a/block/blk-throttle.c >> > +++ b/block/blk-throttle.c >> > @@ -211,15 +211,14 @@ static struct throtl_data *sq_to_td(struct >> > throtl_service_queue *sq) >> > * >> > * The messages are prefixed with "throtl BLKG_NAME" if @sq belongs to a >> > * throtl_grp; otherwise, just "throtl". >> > - * >> > - * TODO: this should be made a function and name formatting should happen >> > - * after testing whether blktrace is enabled. >> >> You've only addressed the second part of the TODO, please don't remove >> the first part. > > alright, I'll send a patch to convert it to a function.
Heh. I figured you'd just put that part of the TODO back in there. But actually addressing it sounds better. ;-) Thanks! Jeff
