Le 09/05/2016 15:15, Lars Ellenberg a écrit :
> On Mon, May 09, 2016 at 11:40:20AM +0200, Nicolas Dichtel wrote:
[snip]
>> Maybe prefixing genl_magic_func.h and genl_magic_struct.h by 'drbd_'
>> could be interesting so that new module won't use it. What is your
>> opinion?
>
> This was supposed to not be DRBD specific. But it might even still
> need some massaging before it was truly generic. And obviously,
> it does not meet the taste of genetlink folks, to say the least :(
Yes, this file is not generic and netlink APIs are never defined like this.
These tons of macro complexifies the code too much. It's overengineering for
what purpose?
Small examples:
- the drbd netlink API is not exported via uapi (I wonder how apps using this
API get it)
- v2 of the patch is nacked because adding a new attribute may break existing
apps (in networking code, a lot of new attributes are added in each version)
- it's not possible to grep to show the definition of an attribute ('git grep
-w T_bits_total' returns only 1 line)
Regards,
Nicolas
